Skip to content

implement proof of concept for du -bkB #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

implement proof of concept for du -bkB #114

merged 1 commit into from
Apr 12, 2025

Conversation

BenWiederhake
Copy link
Contributor

@BenWiederhake BenWiederhake commented Mar 30, 2024 •
edited
Loading

This PR demonstrates how easily the partial-override semantics can be achieved without clap.

Example:

$ du -k LICENSE 
4    LICENSE
$ du -bk LICENSE 
2    LICENSE
$ du -kb LICENSE 
1056    LICENSE

Although this PR technically doesn't depend on #113, I developed on top of it to reduce conflicts, and hence mark this as draft.

Related: #15

@BenWiederhake BenWiederhake marked this pull request as draft March 30, 2024 18:47
@BenWiederhake BenWiederhake marked this pull request as ready for review April 11, 2025 22:53
@BenWiederhake
Copy link
Contributor Author

Changes since last push:

  • Rebased, slightly rephrased
  • fixed date typos (ugh)
  • simplified #[arg] declarations

tertsdiepraam
tertsdiepraam reviewed Apr 12, 2025
View reviewed changes
@BenWiederhake
Copy link
Contributor Author

Changes since last push:

  • actually fixed date typos (ugh)
  • actually simplified #[arg] declarations

@tertsdiepraam tertsdiepraam merged commit 3e7b411 into uutils:main Apr 12, 2025
4 checks passed
BenWiederhake added a commit to BenWiederhake/coreutils-rs that referenced this pull request Apr 12, 2025
@BenWiederhake
du: demonstrate importance of argument order
badd557 
This is essentially the test for uutils/uutils-args#114 .
@BenWiederhake BenWiederhake deleted the dev-du branch April 12, 2025 14:42
@BenWiederhake BenWiederhake mentioned this pull request Apr 12, 2025
Draft
BenWiederhake added a commit to BenWiederhake/coreutils-rs that referenced this pull request Apr 16, 2025
@BenWiederhake
du: demonstrate importance of argument order
a0fe6d3 
This is essentially the test from uutils/uutils-args#114 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWiederhake @tertsdiepraam