Skip to content

fix(valid-define-options): Allow the use of simple constants #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 3, 2025
Merged

fix(valid-define-options): Allow the use of simple constants #2920

merged 10 commits into from
Sep 3, 2025
+20 −1

Conversation

FrontEndDog
Copy link
Contributor

@FrontEndDog FrontEndDog commented Aug 29, 2025 •
edited by FloEdelmann
Loading

Fixes #2919

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9536f05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FrontEndDog FrontEndDog changed the title feat(valid-define-options): Add allowVariableNamePattern fix(valid-define-options): Allow the use of string constants Sep 2, 2025
@FloEdelmann FloEdelmann marked this pull request as draft September 2, 2025 12:13
@FrontEndDog FrontEndDog changed the title fix(valid-define-options): Allow the use of string constants fix(valid-define-options): Allow the use of simple constants Sep 3, 2025
@FrontEndDog FrontEndDog marked this pull request as ready for review September 3, 2025 03:52
@FrontEndDog FrontEndDog mentioned this pull request Sep 3, 2025
Closed
FloEdelmann
FloEdelmann reviewed Sep 3, 2025
View reviewed changes
@FrontEndDog

This comment was marked as resolved.

Sign in to view
@FloEdelmann

This comment was marked as resolved.

Sign in to view
@FloEdelmann

This comment was marked as resolved.

Sign in to view
waynzh
waynzh approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FloEdelmann
FloEdelmann approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@FloEdelmann FloEdelmann merged commit a5127b0 into vuejs:master Sep 3, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Sep 3, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@waynzh waynzh waynzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support literal constant references in vue/valid-define-options rule
3 participants
@FrontEndDog @FloEdelmann @waynzh