Cli patch #135
Closed
Cli patch #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure error is caught and appropriate message displayed. Currently just throws an error if there's an issue in the request:
/usr/local/lib/node_modules/vue-cli/bin/vue-list:29
JSON.parse(body).forEach(function (repo) {
^
TypeError: JSON.parse(...).forEach is not a function
Easier to read on narrow windows.
Formatting
| _body.length) { | ||
| console.log(' Available official templates: \n') | ||
| _body.forEach(function (repo) { | ||
| console.log('%s %s - %s', |
There was a problem hiding this comment.
Aren't you missing some whitespace from lines 31 to 32?
|
@posva Made a few changes based on your comments. Let me know if there's anything else. |
|
@TJKoury Are you looking into tests? |
|
Huh, strange it was passing before. I'll check it out. |
|
Already fixed with #131 |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the talk this morning tried to run 'vue list' but ran up against API rate limit (as we're all hitting the server). This helps handle the error gracefully.