Skip to content

Cli patch #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Cli patch #135

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b327f2
Catch err and display message
TJKoury Jul 28, 2016
e779016
Update format
TJKoury Jul 28, 2016
7c729c7
Formatting
TJKoury Jul 28, 2016
1df4a3b
Check return length
TJKoury Jul 28, 2016
3d1c33a
Formatting
TJKoury Jul 28, 2016
301e22c
Update vue-list
TJKoury Jul 28, 2016
ab3ca22
Update vue-list
TJKoury Aug 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions bin/vue-list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
var logger = require('../lib/logger')
var request = require('request')
var chalk = require('chalk')
var templateUrl = 'https://api.github.com/users/vuejs-templates/repos'

/**
* Padding.
Expand All @@ -18,18 +19,32 @@ process.on('exit', function () {
*/

request({
url: 'https://api.github.com/users/vuejs-templates/repos',
url: templateUrl,
headers: {
'User-Agent': 'vue-cli'
}
}, function (err, res, body) {
if (err) logger.fatal(err)
console.log(' Available official templates:')
console.log()
JSON.parse(body).forEach(function (repo) {
console.log(
' ' + chalk.yellow('★') +
' ' + chalk.blue(repo.name) +
' - ' + repo.description)
})
if (err) {
logger.fatal(err)
} else {
body = JSON.parse(body)
if (Array.isArray(body) &&
body.length) {
console.log(' Available official templates: \n')
body.forEach(function (repo) {
console.log('%s %s - %s',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you missing some whitespace from lines 31 to 32?

chalk.yellow('★'),
chalk.blue(repo.name),
repo.description)
})
} else if (!body.length) {
console.log('%s %s',
chalk.yellow('No Templates found:'),
templateUrl)
} else if (body.hasOwnProperty('message')) {
console.log(chalk.yellow(_body.message))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this when the API has an issue? If so, it may be valuable to say it

} else {
console.log(body)
}
}
})