-
Notifications
You must be signed in to change notification settings - Fork 918
[Korean Docs] Update docs for v12.x #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @kazupon Can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for PR! :)
I reviewed it 👀
Please check my comments 💬
loader: 'vue', | ||
options: { | ||
loaders: { | ||
// extract all <docs> content as raw text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to translate also here?
] | ||
}, | ||
plugins: [ | ||
// output all docs into a single file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to translate also here?
|
||
#### docs-loader.js | ||
|
||
In order for the custom block content to be injected, we'll need a custom loader: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to translate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/kr/features/postcss.md
Outdated
|
||
- PostCSS 프로세서에 전달할 옵션을 포함하는 객체. 이것은 사용자 정의 파서/문자열 변환기에 의존하는 PostCSS 프로젝트를 사용할 때 유용합니다. | ||
- An object that contains options to be passed to the PostCSS processor. This is useful when you are using PostCSS projects that relies on custom parser/stringifiers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right
Thanks @kazupon !! I made so many mistakes 😭 Please check latest commit 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks 👍 Does it automatically apply to https://vue-loader.vuejs.org/kr ? |
additionally, https://router.vuejs.org/kr/ is not have latest version of vue-router repo. |
update vue-loader & vue-router docs done! |
No description provided.