Skip to content

[Korean Docs] Update docs for v12.x #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 2, 2017
Merged

Conversation

ChangJoo-Park
Copy link

No description provided.

@ChangJoo-Park
Copy link
Author

ping @kazupon Can you review this PR?

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR! :)

I reviewed it 👀
Please check my comments 💬

loader: 'vue',
options: {
loaders: {
// extract all <docs> content as raw text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to translate also here?

]
},
plugins: [
// output all docs into a single file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to translate also here?


#### docs-loader.js

In order for the custom block content to be injected, we'll need a custom loader:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to translate here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


- PostCSS 프로세서에 전달할 옵션을 포함하는 객체. 이것은 사용자 정의 파서/문자열 변환기에 의존하는 PostCSS 프로젝트를 사용할 때 유용합니다.
- An object that contains options to be passed to the PostCSS processor. This is useful when you are using PostCSS projects that relies on custom parser/stringifiers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right

@ChangJoo-Park
Copy link
Author

Thanks @kazupon !! I made so many mistakes 😭

Please check latest commit 😄

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kazupon kazupon merged commit 7db1b25 into vuejs:master May 2, 2017
@ChangJoo-Park
Copy link
Author

ChangJoo-Park commented May 2, 2017

Thanks 👍

Does it automatically apply to https://vue-loader.vuejs.org/kr ?

@ChangJoo-Park
Copy link
Author

additionally, https://router.vuejs.org/kr/ is not have latest version of vue-router repo.

@kazupon
Copy link
Member

kazupon commented May 3, 2017

update vue-loader & vue-router docs done!
please check these. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants