CRD: preserve unknown fields and add to all category #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e254d02 to
1a31025
Compare
|
👍 |
|
👍 |
Closed
PetterSa
pushed a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
* CRD: preserve unknown fields and add to all category * allow Pg13 * left over
PetterSa
added a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #746 we switched the CRDs to
v1. It seems that this api version does require to explicitly enable preserving unknown fields (e.g. whenever we allow full specs). Plus, the toggle moved fromcrd.specto the schema.This PR will also register the Postgres Operator CRDs in the
allcategory, so that they are listed whenkubectl get allis executed.fixes #1206