Skip to content

move to apiextensions from v1beta1 to v1 #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2020
Merged

move to apiextensions from v1beta1 to v1 #746

merged 4 commits into from
Nov 2, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Dec 2, 2019 •
edited
Loading

v1beta1 is marked as deprecated in K8s 1.16. CRD structure changes from:

spec:
  additionalPrinterColumns: {}
  subresources:
    status: {}
  version: v1
  validation:
    openAPIV3Schema: {}

spec:
  versions:
    name: v1
    additionalPrinterColumns: {}
    subresources:
      status: {}
    schema:
      openAPIV3Schema: {}

EDIT: v1 for CRDs is not available before v1.16 (see this thread) which results into this error:

no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"

So this PR has to wait. When creating CRDs on v1.16 clusters, they will get transformed into the new schema, for what we saw in tests.

@Jan-M Jan-M added the zalando label Jan 27, 2020
@FxKu FxKu force-pushed the move-to-apiextension-v1 branch from f16fc71 to aecc6e8 Compare September 21, 2020 11:19
@FxKu FxKu force-pushed the move-to-apiextension-v1 branch from f350742 to ce80e5b Compare September 21, 2020 11:24
@Hades32
Copy link

Hades32 commented Oct 13, 2020

I'm getting errors in Helm about this now. Seems it has moved to a hard-deprecation...

Could you re-base this PR?

@sdudoladov sdudoladov mentioned this pull request Oct 29, 2020
Closed
@sdudoladov
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Nov 2, 2020

👍

@FxKu FxKu merged commit d764195 into master Nov 2, 2020
@FxKu FxKu mentioned this pull request Nov 13, 2020
Merged
PetterSa pushed a commit to PetterSa/postgres-operator that referenced this pull request Nov 19, 2020
@FxKu @PetterSa
move to apiextensions from v1beta1 to v1 (zalando#746)
c4d5363 
* move to apiextensions from v1beta1 to v1

* remove metadata from CRD validation

* some forgotten change
PetterSa added a commit to PetterSa/postgres-operator that referenced this pull request Nov 19, 2020
@PetterSa
Revert "move to apiextensions from v1beta1 to v1 (zalando#746)"
c78d522 
This reverts commit c4d5363.
@FxKu FxKu mentioned this pull request Nov 23, 2020
Merged
@FxKu FxKu added this to the 1.6 milestone Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaczi avaczi Awaiting requested review from avaczi

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@erthalion erthalion Awaiting requested review from erthalion

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@RafiaSabih RafiaSabih Awaiting requested review from RafiaSabih

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

Assignees
No one assigned
Labels
zalando
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@FxKu @Hades32 @sdudoladov @Jan-M