preserving fields only when using k8s specs #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
referenced
this pull request
Nov 24, 2020
* move to apiextensions from v1beta1 to v1 * remove metadata from CRD validation * some forgotten change
Jan-M
reviewed
Nov 24, 2020
Jan-M
reviewed
Nov 24, 2020
sdudoladov
reviewed
Nov 24, 2020
| @@ -532,6 +532,11 @@ func (in *PostgresSpec) DeepCopyInto(out *PostgresSpec) { | |||
| *out = new(bool) | |||
| **out = **in | |||
| } | |||
| if in.EnableReplicaConnectionPooler != nil { | |||
| in, out := &in.EnableReplicaConnectionPooler, &out.EnableReplicaConnectionPooler | |||
There was a problem hiding this comment.
Why was this code generated ? was there any change to the connection pooler ?
There was a problem hiding this comment.
Yes, and seem the generated code wasn't updated.
There was a problem hiding this comment.
not very good, but let's commit it in this PR with a commit message acknowledging this fix
|
👍 |
1 similar comment
|
👍 |
|
how to use this image? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PostgresqlCRD has been messed up by #746. This PR cleans it up. Plus for validation it replacesadditionalPropertieswithXPreserveUnknownFields: trueon the object level wherever we allow K8s specs in our custom resources.Tries to fix #1206