-
Notifications
You must be signed in to change notification settings - Fork 79
ValueGenerator recursive setIndentation #163
Comments
Ref: zend-code/src/Generator/ValueGenerator.php Line 363 in 4a7f678
|
@hxss you mean that multiline-dumped values are not aligned? Doesn't sound like a big deal to me... |
@Ocramius please see this example: $generator = new Zend\Code\Generator\ValueGenerator([
'a' => [
'b' => [
'c' => 'd',
]
],
]);
$generator->setIndentation("\t");
echo $generator->generate(); output: array(
'a' => array(
'b' => array(
'c' => 'd',
),
),
) We have 1 tab before |
Yeah, this is not fixable, unless we touch the This is too much risk (really, it's not that trivial) for a problem in alignment, so I'm going to close it as "won't fix", sorry. |
after 363 line need to append zend-code/src/Generator/ValueGenerator.php Line 363 in 4a7f678
|
@Ocramius in my test |
@hxss send a patch then: re-opening (also: didn't know the value generator could already do that, thanks for checking!) |
Please remember to add a test case, if yo do |
Handled in #164 |
On 363 line ValueGenerator creates childs but dont pass to them self indentation. So when I create new ValueGenerator and use
setIndentation
method I can set only first level childs indentation.The text was updated successfully, but these errors were encountered: