This repository was archived by the owner on Jan 29, 2020. It is now read-only.
recursively set indentations for child arrays #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Oct 23, 2018
hxss
commented
Oct 23, 2018
Ocramius
suggested changes
Oct 23, 2018
| * | ||
| * @return array | ||
| */ | ||
| public function complexArrayWCustomIndent() |
| /** | ||
| * Data provider for testPropertyDefaultValueCanHandleComplexArrayWCustomIndentOfTypes test | ||
| * | ||
| * @return array |
| * @param array $value | ||
| * @param string $expected | ||
| */ | ||
| public function testPropertyDefaultValueCanHandleComplexArrayWCustomIndentOfTypes($type, array $value, $expected) |
There was a problem hiding this comment.
Please add type declarations to the parameters: drop them from the docblock
hxss
commented
Oct 23, 2018
|
Check the failures, something is not working as expected: https://travis-ci.org/zendframework/zend-code/jobs/445104487#L653 |
hxss
commented
Oct 23, 2018
|
CS checks still fail: https://travis-ci.org/zendframework/zend-code/jobs/445361931#L675-L744 |
|
lol. TABS > spaces |
|
Last one: https://travis-ci.org/zendframework/zend-code/jobs/445367598#L675-L680 Maybe one level of nesting less would suffice 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #163
I was use auto generated complex arrays with personal data for tests, so I cant publish it.