This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix generateShortOrCompleteClassname #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
As mentioned by @veewee, a test case is strictly required for fixes to be merged. |
|
Yes! Nice to see it fixed so quick! |
|
@qRoC I really want to get this in, but I really need a test case, for a couple of reasons:
Any chance you can get a test in ASAP so I can do a 3.0.4 release, please? |
|
yes |
| $classGenerator = new ClassGenerator(); | ||
| $classGenerator->setName('ClassName'); | ||
| $classGenerator->setExtendedClass('\DateTime'); | ||
| $this->assertContains('class ClassName extends DateTime', $classGenerator->generate()); |
There was a problem hiding this comment.
Please create new test methods for these two new cases, using a name descriptive of the behavior being tested, and annotate them with @group 75.
Thanks!
This was referenced Jun 29, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
Fix generateShortOrCompleteClassname
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
basz
added a commit
to basz/zend-code
that referenced
this pull request
Sep 28, 2016
* 'master' of https://github.com/zendframework/zend-code: (39 commits) Fix Travis code convention Fix Travis code convention Fix Travis code convention Fix Travis code convention 1. Fix ClassScanner::getInterfaces() which don't work with Interface. 2. add TestCase ClassScannerTest::testGetInterfacesFromInterface(). Remove fast_finish flag Bumped to next dev version (3.0.5) Added CHANGELOG for zendframework#75 Separated new tests to separate methods testCorrectExtendNamesFromGlobalNamespace add tests Added CHANGELOG for zendframework#59 Update ClassGenerator.php fast fix Bumped to next dev version (3.0.4) Set date for 3.0.3 Added CHANGELOG for zendframework#72 Added CHANGELOG for zendframework#69 Added CHANGELOG for zendframework#61 Provide a fix for issue zendframework#70 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.