This repository was archived by the owner on Jan 29, 2020. It is now read-only.
ensure there is only 1 leading NS_SEPARATOR #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remicollet duplicate of #75 ? |
|
Yes, it look like. |
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2016
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
Ocramius
added a commit
to Ocramius/ProxyManager
that referenced
this pull request
Jul 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug intriduced in 4a6f4ab
@Ocramius can you please look at this patch.
It seems ProxyManager is broken because of this bug, tons of classes are generated with 2 leading NS_SEPARATOR
Example:
Which raise Parse Errors during proxymanager test suite.