Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Try to use AuthenticationServiceInterface for the Identity helper #155

Merged
merged 7 commits into from
Dec 6, 2018
Merged

Try to use AuthenticationServiceInterface for the Identity helper #155

merged 7 commits into from
Dec 6, 2018

Conversation

gszy
Copy link
Contributor

@gszy gszy commented Jun 17, 2018

froschdesign
froschdesign previously requested changes Jul 13, 2018
View reviewed changes
@froschdesign froschdesign added this to the 2.10.1 milestone Jul 13, 2018
froschdesign
froschdesign reviewed Jul 13, 2018
View reviewed changes
@gszy
Copy link
Contributor Author

gszy commented Jul 13, 2018

@froschdesign, updated.

@froschdesign froschdesign modified the milestones: 2.10.1, 2.11.0 Nov 12, 2018
@froschdesign
Copy link
Member

Please use the develop branch and add also an unit test for the factory. (Hint: look at your own PR on zend-mvc-plugin-identity 😉)

Thank you in advance!

@gszy gszy changed the base branch from master to develop November 20, 2018 12:22
@gszy gszy changed the title Try to use AuthenticationServiceInterface for the Identity helper WIP: Try to use AuthenticationServiceInterface for the Identity helper Nov 20, 2018
@gszy gszy changed the title WIP: Try to use AuthenticationServiceInterface for the Identity helper Try to use AuthenticationServiceInterface for the Identity helper Nov 20, 2018
gszy and others added 7 commits December 6, 2018 16:26
@gszy @weierophinney
Try to use AuthenticationServiceInterface for the Identity helper
966894c 
See zendframework/zend-mvc-plugin-identity#9

Closes #33
@gszy @weierophinney
Use ::class instead of string to identify Zend\Authentication classes
0e4979f
@gszy @weierophinney
IdentityFactoryTest
c19356a
@gszy @weierophinney
Updated the Identity plugin docs
a86effa 
It supports both `AuthenticationService` and
`AuthenticationServiceInterface`.
@weierophinney
Minor doc improvements for #155
2554cf2
@weierophinney
Minor refactor: extract method
3feaeaf 
Extracts the method `discoverAuthenticationService()` from
`IdentityFactory::__invoke()`, allowing removal of an if/else, and
simplifying the logic of the main factory method.
@weierophinney
Adds CHANGELOG entry for #155
fcdeea8
@weierophinney weierophinney dismissed froschdesign’s stale review December 6, 2018 22:36

Author provided changes as requested.

@weierophinney weierophinney merged commit fcdeea8 into zendframework:develop Dec 6, 2018
@weierophinney
Copy link
Member

Thanks, @gscscnd!

@gszy gszy deleted the use-authenticationserviceinterface-in-identity-view-helper branch December 7, 2018 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@froschdesign froschdesign froschdesign left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gszy @froschdesign @weierophinney