Page MenuHomePhabricator

VisualEditor: Tool to set/unset text color
Open, LowPublicFeature

Assigned To
None
Authored By
Thryduulf
Aug 8 2013, 10:12 AM
Referenced Files
Restricted File
Jan 20 2024, 1:14 PM
Restricted File
Jan 20 2024, 1:14 PM
F41702256: image.png
Jan 20 2024, 1:01 PM
Tokens
"Evil Spooky Haunted Tree" token, awarded by Urfiner.

Description

VisualEditor needs a tool to set/unset font colour.


Version: unspecified
Severity: enhancement

Details

Reference
bz52645

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:00 AM
bzimport set Reference to bz52645.

Do we want to do this as a general colour-picker widget, possibly?

Any pros/cons of handling this by wrapping colored text in span with appropriate value of style tag?

  • Bug 51409 has been marked as a duplicate of this bug. ***

(In reply to comment #2)

Any pros/cons of handling this by wrapping colored text in span with
appropriate value of style tag?

Yeah, that's what we'll want to do.

We'll want to supply a generic <span> editor (which lets you edit the style="…" tag as raw CSS) at some point, but we'd want to do something about colour sooner (and nicer), I think.

I think this will be difficult to implement well. I see two concerns:

  • extraneous (noöp) <span>s being left behind in the wikimarkup; and
  • <span>s that specify the color black (bad for accessibility, etc.).

There may be some generic "clear formatting" button/apparatus to be used to mitigate the second point, but I'm still wary.

(In reply to comment #5)

I think this will be difficult to implement well. I see two concerns:

  • extraneous (noöp) <span>s being left behind in the wikimarkup; and

This is the same as bug 37835 and is trivial for us to trim out.

  • <span>s that specify the color black (bad for accessibility, etc.).

Yes, though we already give people loads of tools that they can (and frequently do) abuse. Technology should serve the community and we should make tools that let them do their job, rather than dictate that they can't do something (or, in this case, that they can but it's hard).

There may be some generic "clear formatting" button/apparatus to be used to
mitigate the second point, but I'm still wary.

There's already a "clear formatting" button provided - it would apply its magic to this too.

(Copied from
https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Textcolor)

Hi there :-)
Just wondering, why there is no feature for "coloring Text". In know, there is a way, to use 'span', but im looking for a feature, with a WYSIWYG-Editor. Any advices, ideas?

Thanks :-)

Would we need to file a separate bug for background text color?

(In reply to Elitre from comment #8)

Would we need to file a separate bug for background text color?

Background colour isn't really a thing we want to encourage. :-) That would be a distinct piece of work; created as bug 73041.

If you meant surface colouring for objects like table cells or <div>s, that's another piece of work again - bug 52180 for table cells, possibly that bug will need to be split for the wider work.

If you mean the "highlight" / "mark" tool, that's yet another one - bug 64376.

Rezonansowy renamed this task from VisualEditor: Tool to set/unset text colour to VisualEditor: Tool to set/unset text color.Dec 16 2018, 5:18 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM
Aklapper removed a subscriber: rmoen.

Just an idea on how it may look like (a bit inspired by BlueSpice)

image.png (281×350 px, 20 KB)

"Custom color" click will open a browser tool to select a custom color (browser tool allows to enter html code so no need to have a separate control for that)

End by analogy -- for colorizing table cells:

{F41702286}

This one would change color for the whole cell (not just for background) -- it might be helpful when people create tables and use color as an additional layer of information. For example like in Ubuntu versions table:

{F41702296}