chore: implement sane default pagination limit for audit logs #13676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Jun 26, 2024
Comment on lines
+20
to
+23
| // A limit of 0 should be interpreted by the SQL query as "null" or | ||
| // "no limit". Do not make this value anything besides 0. | ||
| Limit: int(parser.PositiveInt32(queryParams, 0, "limit")), | ||
| Offset: int(parser.PositiveInt32(queryParams, 0, "offset")), |
There was a problem hiding this comment.
Added this comment similar to the -1 one before. Should clear it up going forward 👍
There was a problem hiding this comment.
Doesn't this comment directly contradict what happens in auditlogs.sql?
b89f062 to
28c3872
Compare
johnstcn
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a comment to protect the "0" limit going forward.