MNT: remove the steps attribute from _BaseComposition
#32040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step attribute from _BaseCompositionstep attribute from _BaseComposition
thomasjpfan
reviewed
Aug 29, 2025
step attribute from _BaseCompositionsteps attribute from _BaseComposition
12f3fc7 to
bef64ed
Compare
|
@thomasjpfan |
thomasjpfan
approved these changes
Aug 31, 2025
jeremiedbb
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Thanks for the PR @sotagg. Indeed the steps class attribute is not used and misleading. The docstring and comments modifications look fine to me.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR removes the unused and misleading
stepsattribute from the_BaseCompositionclass. This attribute served no functional purpose since subclasses define their own attributes in__init__()(e.g.,PipelineusesstepswhileColumnTransformerusestransformers).I also updated the docstring to better explain the design pattern.
Any other comments?