Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(service_name): add service schema grpc #5808

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

divyatagauchan
Copy link
Contributor

@divyatagauchan divyatagauchan commented May 8, 2023

What's changing in this PR?
This PR introduces the initial changes for "(2) Standardizing all tracer libraries to using the current application name as a default for existing services (service naming)". The major changes in this revision are:

Create a new concept, 'span attribute schema,' which controls the service naming behavior and control it with a new environment variable DD_TRACE_SPAN_ATTRIBUTE_SCHEMA.
Create 'v0' (existing behavior) and 'v1' (new behavior) schemas and behaviors:
v0 (Default) - The existing behavior
v1 - Default integration service names are now set to the value of
$DD_SERVICE (config().service) instead of the prior default values

Specifically for the GRPC integration. Other PRs are being merged for the other integrations.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • OPTIONAL: PR description includes explicit acknowledgement of the performance implications of the change as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@divyatagauchan divyatagauchan requested a review from a team as a code owner May 8, 2023 20:36
@divyatagauchan divyatagauchan marked this pull request as draft May 8, 2023 20:37
@ZStriker19 ZStriker19 changed the title divyata_add_service_schema_grpc chore(service_name): add service schema grpc May 9, 2023
@ZStriker19 ZStriker19 added the changelog/no-changelog A changelog entry is not required for this PR. label May 9, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2023

Benchmarks

Comparing candidate commit 79e40cd in PR branch divyata_add_service_schema_grpc with baseline commit 9146377 in branch 1.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 cases.

@divyatagauchan divyatagauchan marked this pull request as ready for review May 16, 2023 17:04
Copy link
Contributor

@ZStriker19 ZStriker19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job!

@ZStriker19 ZStriker19 enabled auto-merge (squash) May 18, 2023 18:30
@tabgok tabgok requested review from tabgok and ZStriker19 May 26, 2023 13:58
@ZStriker19 ZStriker19 force-pushed the divyata_add_service_schema_grpc branch from 279fbb0 to 792215e Compare May 31, 2023 21:35
@ZStriker19 ZStriker19 force-pushed the divyata_add_service_schema_grpc branch from 792215e to 963f5ee Compare May 31, 2023 21:57
@ZStriker19 ZStriker19 merged commit bee95d6 into 1.x Jun 1, 2023
@ZStriker19 ZStriker19 deleted the divyata_add_service_schema_grpc branch June 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants