-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(service_name): add service schema grpc #5808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZStriker19
reviewed
May 9, 2023
ZStriker19
reviewed
May 9, 2023
ZStriker19
reviewed
May 16, 2023
ZStriker19
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great job!
tabgok
approved these changes
May 26, 2023
ZStriker19
approved these changes
May 30, 2023
279fbb0
to
792215e
Compare
792215e
to
963f5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing in this PR?
This PR introduces the initial changes for "(2) Standardizing all tracer libraries to using the current application name as a default for existing services (service naming)". The major changes in this revision are:
Create a new concept, 'span attribute schema,' which controls the service naming behavior and control it with a new environment variable DD_TRACE_SPAN_ATTRIBUTE_SCHEMA.
Create 'v0' (existing behavior) and 'v1' (new behavior) schemas and behaviors:
v0 (Default) - The existing behavior
v1 - Default integration service names are now set to the value of
$DD_SERVICE (config().service) instead of the prior default values
Specifically for the GRPC integration. Other PRs are being merged for the other integrations.
Checklist
Reviewer Checklist