Skip to content

fix(core): Corrected background color between Label and nested spans #10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Feb 20, 2025

PR Checklist

What is the current behavior?

There are cases when TextBase and Span background colors mismatch.
That is very apparent when tapping a button with spans and css :pressed pseudo-state.

What is the new behavior?

Spans will be colorless (transparent) to display TextBase parent background color unless they or their FormattedString parents have a background color of their own.
This issue was partially fixed on android but also broke FormattedString color inheritance, so this PR fixes that too (see #10682).

Fixes/Closes #7379 .

@CatchABus CatchABus changed the title fix(ios): Corrected background color mismatch between Label and nested spans fix(ios): Corrected background color between Label and nested spans Feb 20, 2025
@CatchABus CatchABus marked this pull request as draft February 20, 2025 11:33
@CatchABus CatchABus changed the title fix(ios): Corrected background color between Label and nested spans fix(core): Corrected background color between Label and nested spans Feb 20, 2025
@CatchABus CatchABus marked this pull request as ready for review February 20, 2025 12:43
@farfromrefug
Copy link
Collaborator

@CatchABus you are a machine! what s your model number ? T5000 ?

@NathanWalker NathanWalker added this to the 8.9 milestone Feb 20, 2025
@NathanWalker
Copy link
Contributor

I would like to second that notion, I think @CatchABus got the bionic chip implanted 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background color applied twice in labels with <span>s
3 participants