Skip to content

Fix weakproxy richcompare #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2022
Merged

Fix weakproxy richcompare #3913

merged 4 commits into from
Jul 18, 2022

Conversation

Karatuss
Copy link
Contributor

Resolve test_weakref::ReferencesTestCase::test_basic_proxy

fix: #3909

Karatuss and others added 3 commits July 18, 2022 16:40
youknowone
youknowone requested changes Jul 18, 2022
View reviewed changes
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 18, 2022
youknowone
youknowone approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing!

@youknowone youknowone merged commit 3664986 into RustPython:main Jul 18, 2022
@Karatuss Karatuss deleted the weakref_richcompare branch July 18, 2022 12:18
@Karatuss Karatuss changed the title Fix weakref richcompare Fix weakproxy richcompare Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

+1 more reviewer

@Snowapril Snowapril Snowapril left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karatuss @youknowone @Snowapril