Skip to content

Write message for todo! macro #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Write message for todo! macro #5504

wants to merge 1 commit into from

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Feb 6, 2025

This pull request writes messages for todo! macros to help debugging.

For example, I met a situation that I cannot know lines where the build fails, when working on #5486.

error: proc macro panicked
  --> pylib/src/lib.rs:14:5
   |
14 |     rustpython_derive::py_freeze!(dir = "./Lib", crate_name = "rustpython_compiler_core");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: message: not yet implemented

After this pull request, I met a helpful message:

error: proc macro panicked
  --> pylib/src/lib.rs:14:5
   |
14 |     rustpython_derive::py_freeze!(dir = "./Lib", crate_name = "rustpython_compiler_core");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: message: not yet implemented: implement SymbolTableBuilder::scan_type_params TypeParam:::ParamSpec

@moreal moreal force-pushed the write-todo-messages branch from b6bc3b8 to 5b5b468 Compare February 6, 2025 14:47
@moreal
Copy link
Contributor Author

moreal commented Feb 6, 2025

Instead leaving todo messages, I complemented the logics in #5505

@moreal moreal closed this Feb 6, 2025
@youknowone
Copy link
Member

I am also open to merge this first and go for other patches later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreal @youknowone