-
Notifications
You must be signed in to change notification settings - Fork 38
initial Commit for draft Bitmap Label directional label #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Probably the simplest approach is to generate the Here are two approaches I can think of:
If you want to get more complex, you could modify the character-by-character blitting function and then adjust the rotation and position of each character individually. This more complex approach would probably use the lowest amount of RAM during the process, since you won't need two bitmaps (like #1 and #2 above). Let me know your thoughts or if you'd like other suggestions. |
Oh! I just remembered that |
@kmatch98 Thanks for the info. |
Four directions are implemented here similar to label:
I am not seeing an easy way to implement TTB, so I think is better to maintain the memory efficiency and if people need text from top to bottom they can use label. Still having problems when anchoring positions, I try to troubleshoot a little but with no luck. I tried version 2.14 of the library and bitmap_label anchor characteristics were working. #140 . I am guessing that we are having problems in the setter, because we are receiving a None as a anchor_position. @kmatch98 thanks for the suggestions, as you can see it make this a lot easier. |
I evaluated this and it works as expected. Right now you are using a different method to achieve left-to-right "LTR" versus the other options. You can achieve "LTR" with Otherwise, it looks good to me. |
@kmatch98 Thank you for the review, as previously mentioned thanks again for point me in the right direction, it was a breeze compared to do the same feature in label after your indications.
For RTL languages we write normal just in the Left-to-right direction, and not mirroring the letters, that is why methods are different. For the downwards, thank it was something that I discover when doing the PR, I was considering adding, but label does not have it, that is why I did not include it. |
Sorry that was a typo. You are right that it is RTL. Keep up the good work. When you are ready I will take another look. |
@kmatch98 what a ride :). As of you just a single little tiny, small tiny little space..... lol and a rabbit whole , anyway I include the UPD -Upside Down. Thanks. |
I think we need to move this check for valid direction out of LabelBase and put it into each of the subclasses since they have slightly different options with I tried making an upside down label like this
but I got this error:
|
@FoamyGuy good point thank you for reviewing, I'll fix that, Thanks |
Deleting duplicate in exampl.rst file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thanks for all of your work on this @jposada202020
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#13 from dhalbert/setup-packages Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.1 from 2.17.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#147 from jposada202020/api_example > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#145 from jposada202020/master > "Increase duplicate code check threshold "
@kmatch98 I will need your help here, as under the hood labels are different, If we want to implement directional label for the bitmaplabel, we need to do a different approach as we do not have the same tools, what would you recommend? do we need a rotation matrix, we need do
-1
and also a rotation.Thanks 🧑🔬