Add documentation for status LED #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 31, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.14 from 3.5.13: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#148 from tekktrik/doc/status-led-connect Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#18 from CedarGroveStudios/main > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#15 from dhalbert/ulab-numpy > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for the behavior of the status LED in the
__init__()parameter to address Issue #120. I went with this way instead of for each method for brevity, but if that would be the preferred method, I'm happy to do it that way!Also changed it so
post()would turn the status LED off after completion like the other HTTP methods.