Skip to content

Check write_value on ESP32-S2 and other ports #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hierophect opened this issue Sep 21, 2020 · 1 comment · Fixed by #5173
Closed

Check write_value on ESP32-S2 and other ports #3447

hierophect opened this issue Sep 21, 2020 · 1 comment · Fixed by #5173
Assignees
@jepler
Labels
nordic spresense
Milestone
Long term

Comments

@hierophect
Copy link
Collaborator

hierophect commented Sep 21, 2020 •
edited
Loading

The STM32 port has recently been modified to properly acknowledge the write_value parameter during SPI reads (#3431). However, numerous ports still ignore it, including ESP32-S2, NRF52, and Spresense. These ports should be tested to see what their behavior during reads actually is, and whether it may cause bugs with certain devices that have been overlooked up to now.
@hierophect hierophect added nordic spresense espressif applies to multiple Espressif chips labels Sep 21, 2020
@hierophect hierophect mentioned this issue Sep 21, 2020
Merged
@tannewt tannewt added this to the 6.x.x - Bug Fixes milestone Sep 21, 2020
@dhalbert dhalbert modified the milestones: 6.x.x - Bug Fixes, 7.0.0 Mar 31, 2021
@jepler jepler removed the espressif applies to multiple Espressif chips label Jul 15, 2021
@jepler
Copy link

jepler commented Jul 15, 2021

This works for sure on esp32-s2 (I was using SD cards with it today), but is appears it's not properly supported on nrf or spresense. Oddly, sdcardio was tested and working on feather sense https://learn.adafruit.com/adafruit-microsd-spi-sdio/feather-sense-adalogger-featherwing.

@jepler jepler modified the milestones: 7.0.0, Long term Jul 15, 2021
jepler added a commit to jepler/circuitpython that referenced this issue Aug 18, 2021
@jepler
Update all implementations of common_hal_busio_spi_read to honor writ…
2b64318 
…e_value

(nrf, rp2040, and cxd56)

.. as well as a misleading comment that said that read always output
zeros.

Closes: adafruit#3447
@jepler jepler mentioned this issue Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jepler jepler

Labels
nordic spresense
Projects
None yet
Milestone
Long term
Development

Successfully merging a pull request may close this issue.

Update all implementations of spi read to honor write_value jepler/circuitpython
4 participants
@tannewt @jepler @dhalbert @hierophect