Skip to content

test(docs-infra): Use the zoneless testing rules #62596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jul 11, 2025

This will spare use the warning logs when the tests run.

      NG0914: The application is using zoneless change detection, but is still loading Zone.js. Consider removing Zone.js to get the full benefits of zoneless. In applications using the Angular CLI, Zone.js is typically included in the "polyfills" section of the angular.json file.

This commit also drops the remaning tests that relied on waitForAsync/fakeAsync/flushMicrotasks

@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Jul 11, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 11, 2025
Copy link

github-actions bot commented Jul 11, 2025

Deployed adev-preview for 2921143 to: https://ng-dev-previews-fw--pr-angular-angular-62596-adev-prev-9f1y0lo4.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche force-pushed the adev/zoneless-tests branch from 02e9c9a to b3f06c9 Compare July 11, 2025 21:12
@JeanMeche JeanMeche changed the title test(docs-infra): Use the zoneless testing rule test(docs-infra): Use the zoneless testing rules Jul 11, 2025
@JeanMeche JeanMeche force-pushed the adev/zoneless-tests branch 2 times, most recently from 14dc922 to dc24286 Compare July 11, 2025 22:47
@JeanMeche JeanMeche requested review from josephperrott and hawkgs and removed request for josephperrott July 11, 2025 22:48
@JeanMeche JeanMeche force-pushed the adev/zoneless-tests branch from dc24286 to 4c73e59 Compare July 11, 2025 22:50
@JeanMeche JeanMeche marked this pull request as ready for review July 11, 2025 23:22
@JeanMeche JeanMeche force-pushed the adev/zoneless-tests branch 2 times, most recently from 6a2f20c to cbae962 Compare July 12, 2025 00:35
This will spare use the warning logs when the tests run.

```
      NG0914: The application is using zoneless change detection, but is still loading Zone.js. Consider removing Zone.js to get the full benefits of zoneless. In applications using the Angular CLI, Zone.js is typically included in the "polyfills" section of the angular.json file.
```
@JeanMeche JeanMeche force-pushed the adev/zoneless-tests branch from cbae962 to 2921143 Compare July 14, 2025 11:30
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Jul 14, 2025
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 2d048d5.

The changes were merged into the following branches: main, 20.1.x

AndrewKushnir pushed a commit that referenced this pull request Jul 14, 2025
This will spare use the warning logs when the tests run.

```
      NG0914: The application is using zoneless change detection, but is still loading Zone.js. Consider removing Zone.js to get the full benefits of zoneless. In applications using the Angular CLI, Zone.js is typically included in the "polyfills" section of the angular.json file.
```

PR Close #62596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants