-
Notifications
You must be signed in to change notification settings - Fork 26.4k
test(docs-infra): Use the zoneless testing rules #62596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deployed adev-preview for 2921143 to: https://ng-dev-previews-fw--pr-angular-angular-62596-adev-prev-9f1y0lo4.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
02e9c9a
to
b3f06c9
Compare
14dc922
to
dc24286
Compare
dc24286
to
4c73e59
Compare
6a2f20c
to
cbae962
Compare
adev/shared-docs/components/search-history/search-history.component.spec.ts
Outdated
Show resolved
Hide resolved
adev/shared-docs/components/search-history/search-history.component.spec.ts
Outdated
Show resolved
Hide resolved
This will spare use the warning logs when the tests run. ``` NG0914: The application is using zoneless change detection, but is still loading Zone.js. Consider removing Zone.js to get the full benefits of zoneless. In applications using the Angular CLI, Zone.js is typically included in the "polyfills" section of the angular.json file. ```
cbae962
to
2921143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR was merged into the repository by commit 2d048d5. The changes were merged into the following branches: main, 20.1.x |
This will spare use the warning logs when the tests run. ``` NG0914: The application is using zoneless change detection, but is still loading Zone.js. Consider removing Zone.js to get the full benefits of zoneless. In applications using the Angular CLI, Zone.js is typically included in the "polyfills" section of the angular.json file. ``` PR Close #62596
This will spare use the warning logs when the tests run.
This commit also drops the remaning tests that relied on
waitForAsync
/fakeAsync
/flushMicrotasks