Skip to content

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 30, 2025

This commit adds the support to the existing "interpolated_signal_not_invoked" diagnostic (even though it's not really a interpolation)

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Aug 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 30, 2025
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from e871f98 to 48d63c5 Compare August 30, 2025 20:37
@JeanMeche JeanMeche marked this pull request as ready for review September 3, 2025 08:44
@pullapprove pullapprove bot requested a review from thePunderWoman September 3, 2025 08:44
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from 48d63c5 to fe1124f Compare September 3, 2025 08:50
…signal diagnostic

This commit adds the support to the existing "interpolated_signal_not_invoked" diagnostic (even though it's not really a interpolation)
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from fe1124f to 8d51d2a Compare September 3, 2025 08:58
@JeanMeche
Copy link
Member Author

G3 has been cleaned-up.

@JeanMeche JeanMeche requested a review from JoostK September 3, 2025 08:58
@eneajaho
Copy link
Contributor

eneajaho commented Sep 3, 2025

Should we add support for ngIf and ngFor or ngSwitch too? Just in case?

@JeanMeche
Copy link
Member Author

With v21, we'll probably enable the migration to @if by default. Not sure it's worth it.

Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compiler Issues related to `ngc`, Angular's template compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants