Skip to content

refactor(compiler-cli): add support for if/switch to the non-invoked … #63502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(compiler-cli): add support for if/switch to the non-invoked … #63502

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 30, 2025 •
edited
Loading

This commit adds the support to the existing "interpolated_signal_not_invoked" diagnostic (even though it's not really a interpolation)

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Aug 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 30, 2025
@JeanMeche JeanMeche mentioned this pull request Aug 30, 2025
Open
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from e871f98 to 48d63c5 Compare August 30, 2025 20:37
@JeanMeche JeanMeche marked this pull request as ready for review September 3, 2025 08:44
@pullapprove pullapprove bot requested a review from thePunderWoman September 3, 2025 08:44
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from 48d63c5 to fe1124f Compare September 3, 2025 08:50
@JeanMeche
refactor(compiler-cli): add support for if/switch to the non-invoked …
8d51d2a 
…signal diagnostic

This commit adds the support to the existing "interpolated_signal_not_invoked" diagnostic (even though it's not really a interpolation)
@JeanMeche JeanMeche force-pushed the control-flow-signal-diag branch from fe1124f to 8d51d2a Compare September 3, 2025 08:58
@JeanMeche
Copy link
Member Author

G3 has been cleaned-up.

@JeanMeche JeanMeche requested a review from JoostK September 3, 2025 08:58
@eneajaho
Copy link
Contributor

eneajaho commented Sep 3, 2025

Should we add support for ngIf and ngFor or ngSwitch too? Just in case?

@JeanMeche
Copy link
Member Author

With v21, we'll probably enable the migration to @if by default. Not sure it's worth it.

thePunderWoman
thePunderWoman approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marklagendijk marklagendijk mentioned this pull request Sep 6, 2025
Closed
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 8, 2025
@JeanMeche JeanMeche removed the request for review from JoostK September 8, 2025 09:57
@atscott
Copy link
Contributor

atscott commented Sep 8, 2025

This PR was merged into the repository by commit 8e8a3fe.

The changes were merged into the following branches: main, 20.2.x

@atscott atscott closed this in 8e8a3fe Sep 8, 2025
atscott pushed a commit that referenced this pull request Sep 8, 2025
@JeanMeche @atscott
refactor(compiler-cli): add support for if/switch to the non-invoked …
35a1d5d 
…signal diagnostic (#63502)

This commit adds the support to the existing "interpolated_signal_not_invoked" diagnostic (even though it's not really a interpolation)

PR Close #63502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@JeanMeche @eneajaho @atscott @thePunderWoman