fix(eslint-plugin-template): [prefer-self-closing-tags] do not treat comments as whitespace #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 996802f.
☁️ Nx Cloud last updated this comment at |
…comments as whitespace
732d7f7 to
996802f
Compare
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 90.53% 90.52% -0.01%
==========================================
Files 179 179
Lines 3559 3557 -2
Branches 600 598 -2
==========================================
- Hits 3222 3220 -2
Misses 183 183
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715
Due to a template parse error that was being suppressed, the valid test case for comments was incorrectly passing.
Comments do not appear in the syntax tree, so we cannot look at the child nodes to determine whether an element is empty. Instead, we need to look at the source code and get the text between the end of the start tag and the start of the end tag. If that is only whitespace, then the element is truly empty.