This repository was archived by the owner on Nov 30, 2018. It is now read-only.
GoogleMapApi and IsReady descriptions are explicit about usage re control object augmentation #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems useful in light of lots of confusion re control objects and GoogleMapApi vs IsReady on SO and in agm issues.
Seems useful in light of confusion on SO and in agm issues.
|
Build is only failing due to bower issues, this looks good. |
nmccready
added a commit
that referenced
this pull request
Jun 14, 2015
GoogleMapApi and IsReady descriptions are explicit about usage re control object augmentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to resolve #1343. Seems like a minor change, but feedback definitely welcome.