-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(form-group): Add multiple breakpoint support for label (Closes #2230) #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2258 +/- ##
==========================================
+ Coverage 66.51% 66.78% +0.26%
==========================================
Files 162 162
Lines 3157 3182 +25
Branches 874 880 +6
==========================================
+ Hits 2100 2125 +25
+ Misses 778 777 -1
- Partials 279 280 +1
Continue to review full report at Codecov.
|
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
Adds support for multiple breakpoint specific label columns and label alignment
Also removes the assumption that the user is using the default of 12 columns (Closes #2230, #1973)
TODO:
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Removes deprecated
feedback
slot and prop.Basic html is no longer supported when using
label
,description
, and validation feedback props.Slots will need to be used if html is required (this addresses concerns for XSS attacks)
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)CHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)