Skip to content

feat(form-group): Add multiple breakpoint support for label (Closes #2230) #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 11, 2018

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 9, 2018

Description of Pull Request:

Adds support for multiple breakpoint specific label columns and label alignment

Also removes the assumption that the user is using the default of 12 columns (Closes #2230, #1973)

TODO:

  • Fix label alignment
  • form-group documentation/examples update
  • update other doc pages that use form-group in examples

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Removes deprecated feedback slot and prop.

Basic html is no longer supported when using label, description, and validation feedback props.
Slots will need to be used if html is required (this addresses concerns for XSS attacks)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the Conventional Commits naming convention (i.e. "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos", "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)

…2230)

Adds support for multiple breakpoint specific label columns and label alignment

Also removes the assumption that the user is using the default of 12 columns (Closes #2230)
@codecov
Copy link

codecov bot commented Dec 9, 2018

Codecov Report

Merging #2258 into dev will increase coverage by 0.26%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2258      +/-   ##
==========================================
+ Coverage   66.51%   66.78%   +0.26%     
==========================================
  Files         162      162              
  Lines        3157     3182      +25     
  Branches      874      880       +6     
==========================================
+ Hits         2100     2125      +25     
+ Misses        778      777       -1     
- Partials      279      280       +1
Impacted Files Coverage Δ
src/components/form-group/form-group.js 85% <88.46%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2322044...8da4392. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Dec 10, 2018
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[b-form-group] Probably unneeded horizontal column calculation
1 participant