Skip to content

[pagination] Refactored button keyboard selection #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 10, 2017
Merged

[pagination] Refactored button keyboard selection #377

merged 22 commits into from
May 10, 2017

Conversation

tmorehouse
Copy link
Member

Not all buttons were keyboard navigable. This addresses this issue. see discussion on #376
Thanks to @charkins for discovering the issue out and providing feedback

tmorehouse added 21 commits May 8, 2017 05:31
@tmorehouse
Merge pull request #20 from bootstrap-vue/master
bf2afa7 
Resync with Master
@tmorehouse
Merge pull request #21 from bootstrap-vue/master
5baa351 
[modal] focusFirst timing tweak (#357)
@tmorehouse
Merge pull request #22 from bootstrap-vue/master
27c0a87 
Resync
@tmorehouse
Merge pull request #24 from bootstrap-vue/master
223e734 
Additional ARIA on navs and dropdown (#358)
@tmorehouse
Merge pull request #25 from bootstrap-vue/master
acb5c9f 
Resync with master
@tmorehouse
Create README.md
00743ae
@tmorehouse
Create meta.json
7b0cd21
@tmorehouse
Create index.json
b78e9ce
@tmorehouse
[docs] Added button-toolbar
2cc56e0
@tmorehouse
ESLint
12db2e7
@tmorehouse
Merge pull request #26 from bootstrap-vue/master
738279f 
[button-toolbar] docs (#368)
@tmorehouse
[scrollspy] Better options handling
06a2ad7 
Better handling of modifiers
A few code optimizations
Removed excess usage comments
@tmorehouse
ESLint
31d372a
@tmorehouse
Merge pull request #27 from tmorehouse/scrollspy
70c9605 
Scrollspy
@tmorehouse
Merge pull request #28 from bootstrap-vue/master
87ef503 
Resync with master
@tmorehouse
Merge pull request #29 from bootstrap-vue/master
7d017fb 
Make isActive a method. (#376)
@tmorehouse
[pagination] Update button references
e91be16
@tmorehouse
[pagination] Update tweaks
d9b8eba
@tmorehouse
ESLint
02cd9b7
@tmorehouse
ESLint
8535aaf
@tmorehouse
[pagination] focusin.self fix
5d69162
@tmorehouse tmorehouse requested a review from pi0 May 10, 2017 19:51
@pi0 pi0 merged commit d5da8e5 into bootstrap-vue:master May 10, 2017
@tmorehouse tmorehouse mentioned this pull request May 11, 2017
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmorehouse @pi0