[carousel] ARIA attributes and keyboard control #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
When links have role="button", screen readers expect them to work like buttons, so they need to have handlers for enter and spake keys (along with the regular click handler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carousel:
Added
aria-attributes androlesfor accessibility. Non-active slides will have aria-hidden="true"Added keyboard navigation to carousel-indicators (by focusing the indicator). Added role button to indicators, and added enter and space key handlers.
When indicators are not focused, pressing left or right keys will go to previous or next slide
When carousel controls/indicators are focused, sliding is paused. When focus leaves carousel, sliding will resume
When in pause mode, the active slide will be focused to allow screen readers to read the slide content (if any)
Added props for labeling the buttons/regions (sr-only text and aria-label text)
Some aria attributes will not aper is an ID is not assigned to the carousel or carousel-slides. It is recommended that each slide have a unique ID, and that the carousel have a unique ID.
Addresses some of #333
button-toolbar (bonus)
Tweaked the focus timing a bit