Skip to content

feat: support RBAC for syncedEnforcer #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 17, 2021
Merged

feat: support RBAC for syncedEnforcer #150

merged 8 commits into from
Aug 17, 2021

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Aug 9, 2021

No description provided.

@Zxilly Zxilly requested a review from nodece August 9, 2021 11:08
@coveralls
Copy link

coveralls commented Aug 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1112587250

Details

  • 174 of 205 (84.88%) changed or added relevant lines in 12 files are covered.
  • 69 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.6%) to 75.01%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/model.ts 5 6 83.33%
src/coreEnforcer.ts 5 7 71.43%
src/util/builtinOperators.ts 23 26 88.46%
src/syncedEnforcer.ts 4 8 50.0%
src/rbac/defaultSyncedRoleManager.ts 4 11 36.36%
src/rbac/internalRoleManager.ts 108 122 88.52%
Files with Coverage Reduction New Missed Lines %
src/util/util.ts 11 65.74%
src/coreEnforcer.ts 27 78.32%
src/model/model.ts 31 76.24%
Totals Coverage Status
Change from base Build 1107690622: -1.6%
Covered Lines: 1247
Relevant Lines: 1592
💛 - Coveralls

@hsluoyz
Copy link
Member

hsluoyz commented Aug 14, 2021

@nodece

nodece
nodece requested changes Aug 15, 2021
View reviewed changes
@Zxilly Zxilly requested a review from nodece August 16, 2021 06:13
nodece
nodece requested changes Aug 16, 2021
View reviewed changes
@Zxilly Zxilly requested a review from nodece August 17, 2021 04:43
Zxilly added 8 commits August 17, 2021 12:59
@Zxilly
feat: add full support for sync Enforcer
a1db4ab 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
refactor: add override sync function
6fcd0f0 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
refactor: remove sync role manager interface
dba4f01 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: remove non-existent type
71d6365 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
feat: add setNamedRoleManager
a657109 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
style: remove comment
f3fd906 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: fix functions
4ffedc1 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly
fix: fix synced undefined
b4c0a09 
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly Zxilly merged commit 2bf4299 into casbin:v1 Aug 17, 2021
github-actions bot pushed a commit that referenced this pull request Aug 22, 2021
@semantic-release-bot
chore(release): 1.0.0-beta.1 [skip ci]
0cb98cf 
# 1.0.0-beta.1 (2021-08-22)

### Bug Fixes

* `getImplicitPermissionsForUser` works with rmMap ([#272](#272)) ([0d59239](0d59239))
* add cache to generateGFunction ([e90bed2](e90bed2))
* add casbin-cpp to supported languages. ([b856734](b856734))
* add check if the adapter implements BatchAdapter ([a415838](a415838))
* add checks fieldValues to remove filtered policy ([6e144fb](6e144fb))
* Add examples. ([5cf950a](5cf950a))
* Add imports and batchFileAdapter implementation. ([3804c3d](3804c3d))
* add missing await ([523ce85](523ce85))
* Add tests for batch operations. ([e6ad7af](e6ad7af))
* Added ABAC policy logic to the private enforcer. ([c6fc487](c6fc487))
* Added util functions and util tests. ([72918bc](72918bc))
* check adapter type ([a74314d](a74314d))
* compatible types ([58242a5](58242a5))
* downgrade expression-eval back to v2.0.0 to avoid semantic-release failure, revert: casbin/node-casbin#222 ([8c0b1fd](8c0b1fd))
* downgrade target from ESNext to ES2017 for building esm ([7dfcf93](7dfcf93))
* fix buildRoleLinks to isolate groups ([0fb6ae7](0fb6ae7))
* fix CasbinJsGetPermissionForUser() ([#251](#251)) ([98c11f1](98c11f1))
* fix errror type ([dc9e5b5](dc9e5b5))
* fix logic error and add unittests ([82124e3](82124e3))
* fix unexpected parser action ([3074fa9](3074fa9))
* getImplicitPermissionsForUser missing domain parameter ([584624c](584624c))
* ignore print model ([f426131](f426131))
* improve load policy line ([9f12511](9f12511))
* improve tokens separator ([687e96f](687e96f))
* improve update into adapter before model ([0e9ccc6](0e9ccc6))
* Merge conflicts. ([7179b17](7179b17))
* remove lodash ([293a852](293a852))
* remove unused import ([2f8801c](2f8801c))
* remove use spread operator with await in array ([6e4f876](6e4f876))
* rename StringAdapter to MemoryAdapter ([aa92d40](aa92d40))
* stackoverflow in getImplicitRolesForUser ([d0fc49f](d0fc49f))
* support comments after expression ([c97cb26](c97cb26))
* Support for loadIncrementalFilteredPolicy ([72c2001](72c2001))
* support pattern function in 3rd args of g ([#199](#199)) ([27005f8](27005f8))
* tests. ([4da5291](4da5291))
* transfer from micromatch to picomatch ([#264](#264)) ([6be1b06](6be1b06))
* update expression-eval ([95de296](95de296))
* use csv-like format ([32ec20d](32ec20d))
* **builtinoperators:** fix function keyMatch3 ([1245aa0](1245aa0)), closes [#214](#214)
* **enforcer.ts:** fix deleteUser and improve deleteRole description ([1e6af16](1e6af16)), closes [#118](#118)
* **rbac:** fix defaultRoleManager hasRole method ([#211](#211)) ([4f3ba65](4f3ba65))
* update casbinJsGetPermissionForUser for v0.1.0 Casbin.js ([#186](#186)) ([6c277e8](6c277e8))

### Features

* add addMatchingFunc to DefaultRoleManager ([cc04e65](cc04e65))
* add BuildIncrementalRoleLinks ([b565005](b565005))
* add casbinJsGetPermissionForUser ([30ae126](30ae126))
* add enforceEx() ([#271](#271)) ([762efd9](762efd9))
* add getImplicitUsersForPermission ([ad9df14](ad9df14))
* add glob pattern to built-in function ([8415fc2](8415fc2))
* add initRmMap ([87f8011](87f8011))
* Add lazyload option at enforcer init method ([#289](https://github.com/casbin/casbin.js/issues/289)) ([e858dcb](e858dcb))
* add named addMatchingFunc ([65d3a26](65d3a26))
* add policyArrayToString and policyStringToArray to util ([e71b40f](e71b40f))
* add priority_policy_explicit support ([#250](#250)) ([763c18e](763c18e))
* add support for `in` operator ([a44c6a9](a44c6a9))
* add sync mode ([70e4e12](70e4e12))
* add unittest ([3cd5b73](3cd5b73))
* add updatePolicy() ([#234](#234)) ([a3218f1](a3218f1)), closes [#235](#235)
* avoid miss initialize() ([1394e8d](1394e8d))
* changing TypeScript target from ES6 to ES2017 ([6f4f50f](6f4f50f))
* controls whether to automatically notify Watcher ([2ce07c2](2ce07c2))
* enforceSync ([ff41f0a](ff41f0a))
* implement csv parser ([f2ddaab](f2ddaab))
* implement string adapater ([fabd784](fabd784))
* implementation cachedEnforcer ([0ace1a6](0ace1a6))
* improve effector for improve performance ([57de7b2](57de7b2))
* support RBAC for syncedEnforcer ([#150](#150)) ([2bf4299](2bf4299))
* sync with upstream ([ca4b572](ca4b572))
* synchronized enforcer ([ecec514](ecec514))
* use new license format ([284d2a4](284d2a4))

### improvement

* convert all management_api to async function ([e9f4d38](e9f4d38))

### BREAKING CHANGES

* **model** addPolicies, removePolicies and removeFilteredPolicy returns [boolean, string[][]]
* - provides a new interface for Effector
* see #
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Oct 30, 2021
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
e607a30 
# 1.0.0 (2021-10-30)

### Bug Fixes

* `getImplicitPermissionsForUser` works with rmMap ([#272](#272)) ([0d59239](0d59239))
* add cache to generateGFunction ([e90bed2](e90bed2))
* add casbin-cpp to supported languages. ([b856734](b856734))
* add check if the adapter implements BatchAdapter ([a415838](a415838))
* add checks fieldValues to remove filtered policy ([6e144fb](6e144fb))
* Add examples. ([5cf950a](5cf950a))
* Add imports and batchFileAdapter implementation. ([3804c3d](3804c3d))
* add missing await ([523ce85](523ce85))
* Add tests for batch operations. ([e6ad7af](e6ad7af))
* Added ABAC policy logic to the private enforcer. ([c6fc487](c6fc487))
* Added util functions and util tests. ([72918bc](72918bc))
* check adapter type ([a74314d](a74314d))
* compatible types ([58242a5](58242a5))
* downgrade expression-eval back to v2.0.0 to avoid semantic-release failure, revert: casbin/node-casbin#222 ([8c0b1fd](8c0b1fd))
* downgrade target from ESNext to ES2017 for building esm ([7dfcf93](7dfcf93))
* fix buildRoleLinks to isolate groups ([0fb6ae7](0fb6ae7))
* fix CasbinJsGetPermissionForUser() ([#251](#251)) ([98c11f1](98c11f1))
* fix errror type ([dc9e5b5](dc9e5b5))
* fix logic error and add unittests ([82124e3](82124e3))
* fix ts4 build configuration ([a5034c8](a5034c8))
* fix unexpected parser action ([3074fa9](3074fa9))
* getImplicitPermissionsForUser missing domain parameter ([584624c](584624c))
* ignore print model ([f426131](f426131))
* improve load policy line ([9f12511](9f12511))
* improve tokens separator ([687e96f](687e96f))
* improve update into adapter before model ([0e9ccc6](0e9ccc6))
* Merge conflicts. ([7179b17](7179b17))
* remove lodash ([293a852](293a852))
* remove unused import ([2f8801c](2f8801c))
* remove use spread operator with await in array ([6e4f876](6e4f876))
* rename StringAdapter to MemoryAdapter ([aa92d40](aa92d40))
* stackoverflow in getImplicitRolesForUser ([d0fc49f](d0fc49f))
* support comments after expression ([c97cb26](c97cb26))
* Support for loadIncrementalFilteredPolicy ([72c2001](72c2001))
* support pattern function in 3rd args of g ([#199](#199)) ([27005f8](27005f8))
* tests. ([4da5291](4da5291))
* transfer from micromatch to picomatch ([#264](#264)) ([6be1b06](6be1b06))
* update expression-eval ([95de296](95de296))
* use csv-like format ([32ec20d](32ec20d))
* **builtinoperators:** fix function keyMatch3 ([1245aa0](1245aa0)), closes [#214](#214)
* **enforcer.ts:** fix deleteUser and improve deleteRole description ([1e6af16](1e6af16)), closes [#118](#118)
* **rbac:** fix defaultRoleManager hasRole method ([#211](#211)) ([4f3ba65](4f3ba65))
* update casbinJsGetPermissionForUser for v0.1.0 Casbin.js ([#186](#186)) ([6c277e8](6c277e8))

### Features

* add addMatchingFunc to DefaultRoleManager ([cc04e65](cc04e65))
* add BuildIncrementalRoleLinks ([b565005](b565005))
* add casbinJsGetPermissionForUser ([30ae126](30ae126))
* add enforceEx() ([#271](#271)) ([762efd9](762efd9))
* add getImplicitUsersForPermission ([ad9df14](ad9df14))
* add glob pattern to built-in function ([8415fc2](8415fc2))
* add initRmMap ([87f8011](87f8011))
* Add lazyload option at enforcer init method ([#289](https://github.com/casbin/casbin.js/issues/289)) ([e858dcb](e858dcb))
* add named addMatchingFunc ([65d3a26](65d3a26))
* add policyArrayToString and policyStringToArray to util ([e71b40f](e71b40f))
* add priority_policy_explicit support ([#250](#250)) ([763c18e](763c18e))
* add support for `in` operator ([a44c6a9](a44c6a9))
* add sync mode ([70e4e12](70e4e12))
* add unittest ([3cd5b73](3cd5b73))
* add updatePolicy() ([#234](#234)) ([a3218f1](a3218f1)), closes [#235](#235)
* avoid miss initialize() ([1394e8d](1394e8d))
* changing TypeScript target from ES6 to ES2017 ([6f4f50f](6f4f50f))
* controls whether to automatically notify Watcher ([2ce07c2](2ce07c2))
* enforceSync ([ff41f0a](ff41f0a))
* Extend multiple sections type of escapeAssertion ([#180](#180)) ([4a8cc10](4a8cc10))
* implement csv parser ([f2ddaab](f2ddaab))
* implement string adapater ([fabd784](fabd784))
* implementation cachedEnforcer ([0ace1a6](0ace1a6))
* improve effector for improve performance ([57de7b2](57de7b2))
* Multiple sections type ([2635601](2635601))
* RBAC with Domains API ([5e49b41](5e49b41))
* support RBAC for syncedEnforcer ([#150](#150)) ([2bf4299](2bf4299))
* sync with upstream ([ca4b572](ca4b572))
* synchronized enforcer ([ecec514](ecec514))
* use new license format ([284d2a4](284d2a4))

### improvement

* convert all management_api to async function ([e9f4d38](e9f4d38))

### BREAKING CHANGES

* **model** addPolicies, removePolicies and removeFilteredPolicy returns [boolean, string[][]]
* - provides a new interface for Effector
* see #
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece Awaiting requested review from nodece

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zxilly @coveralls @hsluoyz @nodece