Add more packages and blocklist more rules #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will not work with our issues reported, so we should not emit issues for them
|
I tested this on some OSS repos and it seems to work well |
dblandin
reviewed
Oct 12, 2017
| "eslint-config-xo-react": "^0.13.0", | ||
| "eslint-config-xo-space": "^0.16.0", | ||
| "eslint-import-resolver-node": "^0.3.1", | ||
| "eslint-import-resolver-webpack": "^0.8.3", |
There was a problem hiding this comment.
We've had trouble with these revolvers in the past. Do we need to include them if we're blocklisting some of the import/ rules?
There was a problem hiding this comment.
I think we do because the blocklisting happens when we report the issues. If we don't have these here, the analysis will error working with the config, right?
There was a problem hiding this comment.
Ahh, probably... sounds good to me.
dblandin
approved these changes
Oct 12, 2017
gdiggs
added a commit
that referenced
this pull request
Nov 6, 2017
Ports #342 to the eslint-4 channel
gdiggs
added a commit
that referenced
this pull request
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.