Skip to content

SSH failed: kex_exchange_identification: banner line contains invalid characters #11530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Jan 9, 2024 · 2 comments · Fixed by #12045
Closed

SSH failed: kex_exchange_identification: banner line contains invalid characters #11530

mafredri opened this issue Jan 9, 2024 · 2 comments · Fixed by #12045
Assignees
@mafredri
Labels
cli Area: CLI s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@mafredri
Copy link
Member

mafredri commented Jan 9, 2024

I just tried to ssh into my workspace, however, I was greeted by the following:

# ssh -X coder.w     
Your license expires in 25 days.
Workspace was stopped, starting workspace to allow connecting to "w"...
kex_exchange_identification: banner line contains invalid characters

So I ran with ssh -vvv:

Your license expires in 25 days.
Workspace was stopped, starting workspace to allow connecting to "w"...
debug1: kex_exchange_identification: banner line 0: You must authenticate with JFrog Artifactory (https://jfrt.cdr.dev) to create a workspace with this template. Visit:
debug1: kex_exchange_identification: banner line 1: 
debug1: kex_exchange_identification: banner line 2:     https://dev.coder.com/external-auth/jfrog
debug1: kex_exchange_identification: banner line 3: 
kex_exchange_identification: banner line contains invalid characters
banner exchange: Connection to UNKNOWN port 65535: invalid format

We need to fix this and be more careful with how/when we output data when establishing SSH connections.
@mafredri mafredri added cli Area: CLI bug labels Jan 9, 2024
@matifali
Copy link
Member

Related to #11367

@mafredri
Copy link
Member Author

@matifali yes, that surfaced the issue, but I'd say it's mostly unrelated otherwise.

@matifali matifali added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Jan 10, 2024
mafredri added a commit that referenced this issue Feb 7, 2024
@mafredri
fix(cli/ssh): prevent stdin/stdout reads/writes in stdio mode
3793256 
Fixes #11530
@mafredri mafredri mentioned this issue Feb 7, 2024
Merged
mafredri added a commit that referenced this issue Feb 7, 2024
@mafredri
fix(cli/ssh): prevent stdin/stdout reads/writes in stdio mode
3be345d 
Fixes #11530
mafredri added a commit that referenced this issue Feb 7, 2024
@mafredri
fix(cli/ssh): prevent stdin/stdout reads/writes in stdio mode
dd1f7c4 
Fixes #11530
mafredri added a commit that referenced this issue Feb 8, 2024
@mafredri
fix(cli/ssh): prevent reads/writes to stdin/stdout in stdio mode (#12045
e659957 
)

Fixes #11530
@spikecurtis spikecurtis mentioned this issue Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
cli Area: CLI s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli/ssh): prevent reads/writes to stdin/stdout in stdio mode coder/coder
2 participants
@mafredri @matifali