feat: add frontend support for enabling automatic workspace updates #10375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
096ade4 to
ce25bba
Compare
|
@aslilac the one issue I'm seeing is that after I submit the form in the workspace settings page the whole form stays disabled until I refresh the page 🤔 |
aslilac
reviewed
Oct 30, 2023
aslilac
reviewed
Oct 30, 2023
aslilac
reviewed
Oct 30, 2023
|
I can't figure out how to reproduce the disabled form, but I'm happy to have a quick debugging session later |
aslilac
reviewed
Oct 30, 2023
aslilac
approved these changes
Oct 31, 2023
| import { Workspace } from "api/typesGenerated"; | ||
| import { | ||
| AutomaticUpdates, | ||
| AutomaticUpdateses, |
There was a problem hiding this comment.
this name sounds like we hired gollum 😂
aslilac
requested changes
Oct 31, 2023
aslilac
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring an update policy for a workspace. Some behavior notes:
Workspace settings page:
Workspace Page (Regular User) -- Policy=Never TemplatePolicy=Always:
Workspace Page (Regular User) -- Policy=Always TemplatePolicy=Disabled:
fixes #7465