add update policy to workspace stats

coder · sreya · Oct 31, 2023 · Oct 20, 2023 · Oct 20, 2023 · Oct 21, 2023
commit 86b0cb70dc8c9e29f050ba3706179c5b13d441c4
diff --git a/site/src/components/Dashboard/DashboardProvider.tsx b/site/src/components/Dashboard/DashboardProvider.tsx
@@ -122,3 +122,11 @@ export const useIsWorkspaceActionsEnabled = (): boolean => {
   const allowWorkspaceActions = experiments.includes("workspace_actions");
   return allowWorkspaceActions && allowAdvancedScheduling;
 };
+
+export const useTemplatePoliciesEnabled = (): boolean => {
+  const { entitlements, experiments } = useDashboard();
+  return (
+    entitlements.features.access_control.enabled &&
+    experiments.includes("template_update_policies")
+  );
+};
diff --git a/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx b/site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsPage.tsx
@@ -10,18 +10,15 @@ import { useTemplateSettings } from "../TemplateSettingsLayout";
 import { TemplateSettingsPageView } from "./TemplateSettingsPageView";
 import { templateByNameKey } from "api/queries/templates";
 import { useOrganizationId } from "hooks";
-import { useDashboard } from "components/Dashboard/DashboardProvider";
+import { useTemplatePoliciesEnabled } from "components/Dashboard/DashboardProvider";
 
 export const TemplateSettingsPage: FC = () => {
   const { template: templateName } = useParams() as { template: string };
   const navigate = useNavigate();
   const orgId = useOrganizationId();
   const { template } = useTemplateSettings();
   const queryClient = useQueryClient();
-  const { entitlements, experiments } = useDashboard();
-  const accessControlEnabled =
-    entitlements.features["advanced_template_scheduling"].enabled &&
-    experiments.includes("template_update_policies");
+  const accessControlEnabled = useTemplatePoliciesEnabled();
 
   const {
     mutate: updateTemplate,

diff --git a/site/src/pages/WorkspacePage/Workspace.tsx b/site/src/pages/WorkspacePage/Workspace.tsx
@@ -191,6 +191,7 @@ export const Workspace: FC<React.PropsWithChildren<WorkspaceProps>> = ({
           quotaBudget={quotaBudget}
           handleUpdate={handleUpdate}
           canUpdateWorkspace={canUpdateWorkspace}
+          canChangeVersions={canChangeVersions}
           maxDeadlineDecrease={scheduleProps.maxDeadlineDecrease}
           maxDeadlineIncrease={scheduleProps.maxDeadlineIncrease}
           onDeadlineMinus={scheduleProps.onDeadlineMinus}

diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/constants.ts b/site/src/pages/WorkspacePage/WorkspaceActions/constants.ts
@@ -43,9 +43,9 @@ export const actionsByWorkspaceStatus = (
     };
   }
   if (
-    workspace.template_require_active_version &&
     workspace.outdated &&
-    !canChangeVersions
+    ((workspace.template_require_active_version && !canChangeVersions) ||
+      workspace.automatic_updates === "always")
   ) {
     if (status === "running") {
       return {

diff --git a/site/src/pages/WorkspacePage/WorkspaceStats.tsx b/site/src/pages/WorkspacePage/WorkspaceStats.tsx
@@ -26,6 +26,12 @@ import {
   PopoverTrigger,
   usePopover,
 } from "components/Popover/Popover";
+import { useTemplatePoliciesEnabled } from "components/Dashboard/DashboardProvider";
+import {
+  HelpTooltip,
+  HelpTooltipText,
+} from "components/HelpTooltip/HelpTooltip";
+import { Stack } from "components/Stack/Stack";
 
 const Language = {
   workspaceDetails: "Workspace Details",
@@ -37,13 +43,15 @@ const Language = {
   upToDate: "Up to date",
   byLabel: "Last built by",
   costLabel: "Daily cost",
+  updatePolicy: "Update policy",
 };
 
 export interface WorkspaceStatsProps {
   workspace: Workspace;
   maxDeadlineIncrease: number;
   maxDeadlineDecrease: number;
   canUpdateWorkspace: boolean;
+  canChangeVersions: boolean;
   quotaBudget?: number;
   onDeadlinePlus: (hours: number) => void;
   onDeadlineMinus: (hours: number) => void;
@@ -56,6 +64,7 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({
   maxDeadlineDecrease,
   maxDeadlineIncrease,
   canUpdateWorkspace,
+  canChangeVersions,
   handleUpdate,
   onDeadlineMinus,
   onDeadlinePlus,
@@ -67,6 +76,13 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({
   const styles = useStyles();
   const deadlinePlusEnabled = maxDeadlineIncrease >= 1;
   const deadlineMinusEnabled = maxDeadlineDecrease >= 1;
+  const templatePoliciesEnabled = useTemplatePoliciesEnabled();
+  const workspaceUpdatePolicy = (): string => {
+    if (workspace.template_require_active_version && !canChangeVersions) {
+      return "Always";
+    }
+    return upperFirst(workspace.automatic_updates);
+  };
 
   return (
     <>
@@ -198,6 +214,25 @@ export const WorkspaceStats: FC<WorkspaceStatsProps> = ({
             }`}
           />
         )}
+        {templatePoliciesEnabled && (
+          <Stack direction="row" spacing={0.5}>
+            <StatsItem
+              className={styles.statsItem}
+              label={Language.updatePolicy}
+              value={workspaceUpdatePolicy()}
+            />
+            {workspace.automatic_updates === "never" &&
+              workspace.template_require_active_version &&
+              !canChangeVersions && (
+                <HelpTooltip>
+                  <HelpTooltipText>
+                    Your workspace has not opted in to automatic updates but
+                    your template requires updating to the active version.
+                  </HelpTooltipText>
+                </HelpTooltip>
+              )}
+          </Stack>
+        )}
       </Stats>
     </>
   );

diff --git a/site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPage.tsx b/site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPage.tsx
@@ -20,7 +20,6 @@ const WorkspaceSettingsPage = () => {
 
   const mutation = useMutation({
     mutationFn: async (formValues: WorkspaceSettingsFormValues) => {
-      console.log("in here", formValues.automatic_updates);
       await patchWorkspace(workspace.id, { name: formValues.name });
       await updateWorkspaceAutomaticUpdates(
         workspace.id,