Skip to content

feat: add frontend support for enabling automatic workspace updates #10375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 31, 2023
Merged

feat: add frontend support for enabling automatic workspace updates #10375

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a66709a
feat: add frontend support for enabling automatic workspace updates
sreya Oct 20, 2023
262050a
cleanup
Kira-Pilot Oct 20, 2023
86b0cb7
add update policy to workspace stats
sreya Oct 21, 2023
ce25bba
revert restrictive behavior
sreya Oct 21, 2023
3602dd9
move workspace setting behind experimental
sreya Oct 21, 2023
2f0ef94
remove unused import
sreya Oct 21, 2023
c68a8b6
Merge branch 'main' into jon/wsautoupdatefe
sreya Oct 30, 2023
e751552
pr comments
sreya Oct 30, 2023
2a67fe3
pr comments
sreya Oct 31, 2023
2018b0b
remove unused prop
sreya Oct 31, 2023
673b214
storybook: add auto updates story
aslilac Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused prop
  • Loading branch information
@sreya
sreya committed Oct 31, 2023
commit 2018b0b525e2314af8149c56bdd4101de15c0c59
10 changes: 4 additions & 6 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,12 @@ export type WorkspaceSettingsFormValues = {
};

export const WorkspaceSettingsForm: FC<{
isSubmitting: boolean;
workspace: Workspace;
error: unknown;
templatePoliciesEnabled: boolean,
templatePoliciesEnabled: boolean;
onCancel: () => void;
onSubmit: (values: WorkspaceSettingsFormValues) => void;
}> = ({ onCancel, onSubmit, workspace, error, isSubmitting, templatePoliciesEnabled }) => {
onSubmit: (values: WorkspaceSettingsFormValues) => Promise<void>;
}> = ({ onCancel, onSubmit, workspace, error, templatePoliciesEnabled }) => {
const form = useFormik<WorkspaceSettingsFormValues>({
onSubmit,
initialValues: {
Expand All @@ -51,7 +50,6 @@ export const WorkspaceSettingsForm: FC<{
error,
);


return (
<HorizontalForm onSubmit={form.handleSubmit} data-testid="form">
<FormSection
Expand Down Expand Up @@ -98,7 +96,7 @@ export const WorkspaceSettingsForm: FC<{
</FormFields>
</FormSection>
)}
<FormFooter onCancel={onCancel} isLoading={isSubmitting} />
<FormFooter onCancel={onCancel} isLoading={form.isSubmitting} />
</HorizontalForm>
);
};
3 changes: 1 addition & 2 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ const WorkspaceSettingsPage = () => {

<WorkspaceSettingsPageView
error={mutation.error}
isSubmitting={mutation.isLoading}
workspace={workspace}
onCancel={() => navigate(`/@${username}/${workspaceName}`)}
onSubmit={mutation.mutate}
onSubmit={mutation.mutateAsync}
templatePoliciesEnabled={templatePoliciesEnabled}
/>
</>
Expand Down
1 change: 0 additions & 1 deletion site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const meta: Meta<typeof WorkspaceSettingsPageView> = {
component: WorkspaceSettingsPageView,
args: {
error: undefined,
isSubmitting: false,
workspace: MockWorkspace,
},
};
Expand Down
3 changes: 0 additions & 3 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Workspace } from "api/typesGenerated";

export type WorkspaceSettingsPageViewProps = {
error: unknown;
isSubmitting: boolean;
workspace: Workspace;
onCancel: () => void;
onSubmit: ComponentProps<typeof WorkspaceSettingsForm>["onSubmit"];
Expand All @@ -15,7 +14,6 @@ export type WorkspaceSettingsPageViewProps = {
export const WorkspaceSettingsPageView: FC<WorkspaceSettingsPageViewProps> = ({
onCancel,
onSubmit,
isSubmitting,
error,
workspace,
templatePoliciesEnabled,
Expand All @@ -32,7 +30,6 @@ export const WorkspaceSettingsPageView: FC<WorkspaceSettingsPageViewProps> = ({

<WorkspaceSettingsForm
error={error}
isSubmitting={isSubmitting}
workspace={workspace}
onCancel={onCancel}
onSubmit={onSubmit}
Expand Down