feat: add endpoint for resolving autostart status #10507
Conversation
4a9bd9c to
38ceb5d
Compare
9abeaaf to
872e214
Compare
|
|
||
| t.Run("OK", func(t *testing.T) { | ||
| t.Parallel() | ||
| ownerClient := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) |
There was a problem hiding this comment.
Can you do this without a ProvisionerDaemon following the new dbfake paradigm introduced here: #10426 ?
There was a problem hiding this comment.
I can make this change but it's not as trivial as it sounds especially because of parameters. Once I finish up this feature I'm planning on helping refactor existing tests using dbfake. Do you care if we push it for now?
There was a problem hiding this comment.
I'm wary of shipping a feature with a "chore" task leftover that we pinky-promise to fix up soon. Once the feature is shipped it's real easy to just put off the chore indefinitely. Even if you created a GitHub ticket, we auto-close stale issues! I'm not questioning your sincerity, but the road to hell is paved with best intentions.
I think debt is a good analogy in this case. You're saying we should take out a loan here. What's so important about shipping this change now such that we want to take the risk of not fixing the tests? Flaky tests are like, the biggest thing on developer's mind judging by our conversation at the offsite.
There was a problem hiding this comment.
Yeah agreed, per our offline conversation I'm going to refactor these in a separate PR.
|
|
||
| ownerClient, owner := coderdenttest.New(t, &coderdenttest.Options{ | ||
| Options: &coderdtest.Options{ | ||
| IncludeProvisionerDaemon: true, |
There was a problem hiding this comment.
ditto, should use dbfake rather than a provisioner daemon
This PR adds an endpoint for determining whether autostart is possible for a workspace. It takes into account whether the template mandates automatic updates or if workspace has opted in to automatic updates. This provides the backend plumbing necessary for #10098.
A separate PR will be opened to handle the frontend implementation.