Skip to content

feat: add support for custom permissions in Helm chart rbac.yaml file #10590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

lbi22
Copy link
Contributor

@lbi22 lbi22 commented Nov 8, 2023

This PR adds support the permission to manage the Kubernetes services inside the coder workspace.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ericpaulsen
Copy link
Member

hi @lbi22 - thank you for your contribution. can you share more context on the use-case?

@lbi22
Copy link
Contributor Author

lbi22 commented Nov 8, 2023

hello @ericpaulsen, in my team we would like to deploy a DB alongside the workspace and having the possibility to create a service to expose the DB will help in the process.

@lbi22
Copy link
Contributor Author

lbi22 commented Nov 8, 2023

I have read the CLA Document and I hereby sign the CLA

@lbi22
Copy link
Contributor Author

lbi22 commented Nov 8, 2023

recheck

cdrcommunity added a commit to coder/cla that referenced this pull request Nov 8, 2023
kylecarbs
kylecarbs previously approved these changes Nov 8, 2023
@kylecarbs
Copy link
Member

@ericpaulsen longer-term we should allow people to just specify custom perms as a property in our Helm instead of these opinionated properties.

Maybe we do that instead of this if it's easy?

@ericpaulsen
Copy link
Member

@ericpaulsen longer-term we should allow people to just specify custom perms as a property in our Helm instead of these opinionated properties.

Maybe we do that instead of this if it's easy?

@kylecarbs yes, I would prefer to do that instead. I can implement.

@lbi22
Copy link
Contributor Author

lbi22 commented Nov 9, 2023

@ericpaulsen @kylecarbs if you want, I can add the block without issue.

@ericpaulsen
Copy link
Member

@ericpaulsen @kylecarbs if you want, I can add the block without issue.

Sure, please add it and I will review.

@ericpaulsen ericpaulsen changed the title feat: add feature to manage Kubernates services with helm feat: add support for custom permissions in Helm chart rbac.yaml file Nov 9, 2023
@lbi22
Copy link
Contributor Author

lbi22 commented Nov 20, 2023

What can we do to unblock the situation?

@deansheather deansheather merged commit 7029ccf into coder:main Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
@lbi22 lbi22 deleted the create-service-in-workspace branch November 27, 2023 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests and issues created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants