fix: lock log sink against concurrent write and close #10668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
31c8047 to
fcd5e39
Compare
johnstcn
approved these changes
Nov 14, 2023
Comment on lines
-140
to
+141
| var logger slog.Logger | ||
| logger := slog.Make() |
There was a problem hiding this comment.
I'm assuming the zero value of a logger is fundamentally unsafe given exit func(int) may be nil.
Should this be a linter rule?
There was a problem hiding this comment.
Actually, it's fine. https://github.com/coder/slog/blob/f0c466fabe10641afdbcc629938df29f941b3d18/slog.go#L148
But, I still like using the constructor for consistency, and in the stacked PR I set it to something else anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10663