Skip to content

ci: build a multi-arch main image #11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

ci: build a multi-arch main image #11668

wants to merge 12 commits into from

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 17, 2024

2nd attempt at #11544
Additionally, we can move the coder build to Dockerfile and build with dpot.dev 16 core 32 GB builder.

@matifali matifali marked this pull request as ready for review January 17, 2024 15:58
@deansheather
Copy link
Member

Additionally, we can move the coder build to Dockerfile and build with dpot.dev 16 core 32 GB builder.

I think we should leave it how it is. We want to ship the same binary everywhere, so it'd be weird to rebuild it in the Docker image compared to the one we ship as a raw binary on github releases.

@matifali
Copy link
Member Author

@deansheather, which one do you prefer? #11544 or this one?

@deansheather
Copy link
Member

@matifali The other one, you shouldn't need depot to build these. We only use depot to build the "base" image, which is built on every release and on a weekly basis and pushed to the base repo. The reason we need depot to build that is because it has RUN statements which cannot be cross-built from amd64. The non-base Dockerfile doesn't contain RUN statements and just has COPY and other statements that can be cross-built. So you should just do that.

@matifali
Copy link
Member Author

matifali commented Jan 17, 2024

@deansheather I understand, but our current approach requires pushing individual arch images to the registry and then pulling those back, creating a manifest, and pushing the manifest. Depot allows removing all that and makes it super easy to push multi-arch images.

@matifali
Copy link
Member Author

After discussing with @deansheather, I am closing in favor of #11544. We do not benefit from the depot.dev as our multi-arch Dockerfile does not have any RUN commands.

@matifali matifali closed this Jan 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
@github-actions github-actions bot deleted the depot-main branch July 18, 2024 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants