chore(site): upgrade msw to 2.0 #12597
Conversation
| // TODO: This test is timing out after upgrade a few Jest dependencies | ||
| // and I was not able to figure out why. When running it specifically, I | ||
| // can see many act warnings that may can help us to find the issue. | ||
| "/usePaginatedQuery.test.ts", |
There was a problem hiding this comment.
@Parkreiner I may need your help with this 🙏 I created a separated issue to not block this one #12598
There was a problem hiding this comment.
No worries! Happy to take a look tomorrow after Backstage launch
There was a problem hiding this comment.
rather than temporarily ignore the file, can we use test.failing on the tests in the file?
There was a problem hiding this comment.
Oh, I didn't realize that was an option. Definitely think we should go with that
There was a problem hiding this comment.
There was a problem hiding this comment.
For some reason, describe.skip or test.failure are not working 😢 it just hangs forever
Screen.Recording.2024-03-14.at.14.54.43.mov
Ps: I tried to post a longer video but GH didn't allow me because of the size.
There was a problem hiding this comment.
that's annoying... what happens if you add an empty non-skipped test?
There was a problem hiding this comment.
it just hangs... I think there is some weird thing happening on this test 🤔
| @@ -37,7 +37,7 @@ function render< | |||
| * There are a lot of test cases in this file. Scoping mocking to inner describe | |||
| * function calls to limit the cognitive load of maintaining all this stuff | |||
| */ | |||
| describe(usePaginatedQuery.name, () => { | |||
| describe.skip(usePaginatedQuery.name, () => { | |||
There was a problem hiding this comment.
nit: maybe you can just import skip?
There was a problem hiding this comment.
Let me see if that works
There was a problem hiding this comment.
skip is not exported directly. It needs to be used with describe, test, or it but something is preventing this to be working properly. I think Kayla found a similar issues on this PR #12538
Closes #11426