fix(cli): add backwards compat for old telemetry env and tests #15476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d23ad21 to
e4eaf58
Compare
f3fa0ba to
1ebcb3b
Compare
dannykopping
approved these changes
Nov 13, 2024
| // Set the default telemetry to true (normally disabled in tests). | ||
| t.Setenv("CODER_TEST_TELEMETRY_DEFAULT_ENABLE", "true") | ||
|
|
||
| //nolint:paralleltest // No need to reinitialise the variable tt (Go version). |
There was a problem hiding this comment.
Nit: we should fix our linter.
Suggested change
| //nolint:paralleltest // No need to reinitialise the variable tt (Go version). | |
| //nolint:paralleltest // No need to reinitialise the variable tt (as of go v1.22). |
johnstcn
approved these changes
Nov 13, 2024
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a backwards compatible
CODER_TELEMETRYenv, currently this is calledCODER_TELEMETRY_ENABLE.Depends on coder/serpent#23
Fixes coder/internal#209
Refs #15467