Skip to content

fix(cli): add backwards compat for old telemetry env and tests #15476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2024
Merged

fix(cli): add backwards compat for old telemetry env and tests #15476

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0a2b4b
fix(cli): add backwards compat for old telemetry env and tests
mafredri Nov 11, 2024
e4eaf58
update serpent to fork
mafredri Nov 11, 2024
9b1e097
lint
mafredri Nov 11, 2024
6f6ddc2
remove debuglog
mafredri Nov 11, 2024
1ebcb3b
bump serpent pr
mafredri Nov 13, 2024
3e60be1
bump serpent pr
mafredri Nov 13, 2024
5a63708
serpent 0.9.0
mafredri Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@mafredri
mafredri committed Nov 11, 2024
commit 9b1e0972be4af3b06a2ab20a163e01d84ebbb7ea
3 changes: 2 additions & 1 deletion cli/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,11 +1620,12 @@ func TestServer_Production(t *testing.T) {
require.NoError(t, err)
}

//nolin:tparallel,paralleltest // This test sets environment variables.
//nolint:tparallel,paralleltest // This test sets environment variables.
func TestServer_TelemetryDisable(t *testing.T) {
// Set the default telemetry to true (normally disabled in tests).
t.Setenv("CODER_TEST_TELEMETRY_DEFAULT_ENABLE", "true")

//nolint:paralleltest // No need to reinitialise the variable tt (Go version).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should fix our linter.

Suggested change
//nolint:paralleltest // No need to reinitialise the variable tt (Go version).
//nolint:paralleltest // No need to reinitialise the variable tt (as of go v1.22).

for _, tt := range []struct {
key string
val string
Expand Down
Loading