Skip to content

chore: improve dormant workspace notification wording #17100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

chore: improve dormant workspace notification wording #17100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521a13b
improve dormant workspace notification wording
defelmnq Mar 25, 2025
b51c005
fix templates
defelmnq Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix templates
  • Loading branch information
@defelmnq
defelmnq committed Mar 26, 2025
commit b51c005c53c2dc4f56c82b319154b8fda9d8a027
4 changes: 2 additions & 2 deletions coderd/database/migrations/000311_improve_dormant_workspace_notification.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
UPDATE notification_templates SET body_template = E'Your workspace **{{.Labels.name}}** has been marked as [**dormant**](https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.' ||
E'This workspace will be automatically deleted in {{.Labels.timeTilDormant}} if it remains inactive.' ||
UPDATE notification_templates SET body_template = E'Your workspace **{{.Labels.name}}** has been marked as [**dormant**](https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.\n\n' ||
E'This workspace will be automatically deleted in {{.Labels.timeTilDormant}} if it remains inactive.\n\n' ||
E'To prevent deletion, activate your workspace using the link below.' WHERE id = '0ea69165-ec14-4314-91f1-69566ac3c5a0';
18 changes: 12 additions & 6 deletions coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDormant.html.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@ Hi Bobby,

Your workspace bobby-workspace has been marked as dormant (https://coder.co=
m/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity =
exceeding the dormancy threshold.This workspace will be automatically delet=
ed in 24 hours if it remains inactive.To prevent deletion, activate your wo=
rkspace using the link below.
exceeding the dormancy threshold.

This workspace will be automatically deleted in 24 hours if it remains inac=
tive.

To prevent deletion, activate your workspace using the link below.


View workspace: http://test.com/@bobby/bobby-workspace
Expand Down Expand Up @@ -53,9 +56,12 @@ argin: 8px 0 32px; line-height: 1.5;">
<p>Your workspace <strong>bobby-workspace</strong> has been marked =
as <a href=3D"https://coder.com/docs/templates/schedule#dormancy-threshold-=
enterprise"><strong>dormant</strong></a> due to inactivity exceeding the do=
rmancy threshold.This workspace will be automatically deleted in 24 hours i=
f it remains inactive.To prevent deletion, activate your workspace using th=
e link below.</p>
rmancy threshold.</p>

<p>This workspace will be automatically deleted in 24 hours if it remains i=
nactive.</p>

<p>To prevent deletion, activate your workspace using the link below.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
4 changes: 2 additions & 2 deletions ...rd/notifications/testdata/rendered-templates/webhook/TemplateWorkspaceDormant.json.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
},
"title": "Workspace \"bobby-workspace\" marked as dormant",
"title_markdown": "Workspace \"bobby-workspace\" marked as dormant",
"body": "Your workspace bobby-workspace has been marked as dormant (https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.This workspace will be automatically deleted in 24 hours if it remains inactive.To prevent deletion, activate your workspace using the link below.",
"body_markdown": "Your workspace **bobby-workspace** has been marked as [**dormant**](https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.This workspace will be automatically deleted in 24 hours if it remains inactive.To prevent deletion, activate your workspace using the link below."
"body": "Your workspace bobby-workspace has been marked as dormant (https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.\n\nThis workspace will be automatically deleted in 24 hours if it remains inactive.\n\nTo prevent deletion, activate your workspace using the link below.",
"body_markdown": "Your workspace **bobby-workspace** has been marked as [**dormant**](https://coder.com/docs/templates/schedule#dormancy-threshold-enterprise) due to inactivity exceeding the dormancy threshold.\n\nThis workspace will be automatically deleted in 24 hours if it remains inactive.\n\nTo prevent deletion, activate your workspace using the link below."
}
Loading