feat: add CODER_WORKSPACE_HOSTNAME_SUFFIX #17268
Merged
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 7, 2025
mafredri
approved these changes
Apr 7, 2025
| @@ -2549,6 +2550,17 @@ func (c *DeploymentValues) Options() serpent.OptionSet { | |||
| Hidden: false, | |||
| Default: "coder.", | |||
| }, | |||
| { | |||
| Name: "Workspace Hostname Suffix", | |||
| Description: "Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is coder, resulting in names like myworkspace.coder.", | |||
There was a problem hiding this comment.
Suggested change
| Description: "Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is coder, resulting in names like myworkspace.coder.", | |
| Description: "Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is \"coder\", resulting in names like myworkspace.coder.", |
Suggestion: To differentiate the value from the text.
|
No, not for a while. I'm marking some internal fields deprecated, but the external behavior isn't deprecated yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deployment option
CODER_WORKSPACE_HOSTNAME_SUFFIX. This will eventually replaceCODER_SSH_HOSTNAME_PREFIX, but we will do this slowly and support both forcoder sshfor some time.Note that the name is changed to "workspace" hostname, since this suffix will also be used for Coder Connect on Coder Desktop, which is not limited to SSH.